Re: audit tree for inclusion in -mm
* Chris Wright (chrisw(a)osdl.org) wrote:
* Steve Grubb (sgrubb(a)redhat.com) wrote:
> On Friday 29 April 2005 13:22, Chris Wright wrote:
> > Good, I had same conclusion (esp. for the straight bug fixes).
>
> What did we decide about the printk issue? Are we going to improve the current
> patch to clamp at byte 1023 so we don't leak memory?
That's one of the bits I'm looking at in David's tree.
Actually looks fine, there is always one free byte in the skb payload
(I missed that earlier). When moving the audit buffer to the skb,
the check for extra room will leave a trailing byte (from the <= check):
if (!skb || skb_tailroom(skb) <= ab->len + extra)
thanks,
-chris