Re: [PATCH] audit: remove some duplicated includes

On Mon, Nov 26, 2018 at 9:51 AM Yangtao Li <tiny.windzz(a)gmail.com&gt; wrote: > > audit.h and skbuff.h are included twice.It's unnecessary. > hence just remove them. > > Signed-off-by: Yangtao Li <tiny.windzz(a)gmail.com&gt; > --- > kernel/audit.c | 3 --- > 1 file changed, 3 deletions(-) While there are two header files named audit.h, they are different files as one lives in include/linux/audit.h, the other in kernel/audit.h. Granted, kernel/audit.h does include the include/linux/audit.h file but it should be protected from multiple inclusion by the _LINUX_AUDIT_H_ definition. I currently prefer to keep both <linux/audit.h> and "audit.h" in audit.c to help make the dependencies explicit in audit.c itself.

> diff --git a/kernel/audit.c b/kernel/audit.c > index 2a8058764aa6..a677715891d0 100644 > --- a/kernel/audit.c > +++ b/kernel/audit.c > @@ -62,11 +62,8 @@ > #include <linux/pid.h> > #include <linux/slab.h> > > -#include <linux/audit.h> > - > #include <net/sock.h> > #include <net/netlink.h> > -#include <linux/skbuff.h> > #ifdef CONFIG_SECURITY > #include <linux/security.h> > #endif > -- > 2.17.0 -- paul moore www.paul-moore.com