Re: [PATCH 05/22] audit: Fix sleep in atomic

On Fri, Dec 23, 2016 at 8:24 AM, Jan Kara <jack(a)suse.cz&gt; wrote: > On Thu 22-12-16 18:18:36, Paul Moore wrote: >> On Thu, Dec 22, 2016 at 4:15 AM, Jan Kara <jack(a)suse.cz&gt; wrote: >> > Audit tree code was happily adding new notification marks while holding >> > spinlocks. Since fsnotify_add_mark() acquires group->mark_mutex this can >> > lead to sleeping while holding a spinlock, deadlocks due to lock >> > inversion, and probably other fun. Fix the problem by acquiring >> > group->mark_mutex earlier. >> > >> > CC: Paul Moore <paul(a)paul-moore.com&gt; >> > Signed-off-by: Jan Kara <jack(a)suse.cz&gt; >> > --- >> > kernel/audit_tree.c | 13 +++++++++++-- >> > 1 file changed, 11 insertions(+), 2 deletions(-) >> >> [SIDE NOTE: this patch explains your comments and my earlier concern >> about the locked/unlocked variants of fsnotify_add_mark() in >> untag_chunk()] >> >> Ouch. Thanks for catching this ... what is your goal with these >> patches, are you targeting this as a fix during the v4.10-rcX cycle? >> If not, any objections if I pull this patch into the audit tree and >> send this to Linus during the v4.10-rcX cycle (assuming it passes >> testing, yadda yadda)? > > Sure, go ahead. I plan these patches for the next merge window. So I can > rebase the series once you merge audit fixes... Okay, great. I'll merge this patch in the audit/stable-4.10 branch for Linus but there will likely be some delays due to holidays/vacation on my end. Thanks again for your help fixing this, I really appreciate it.