Re: [PATCH 1/2] security/smack implement logging V3
Eric Paris wrote:
On Wed, 2009-04-08 at 20:39 +0200, Etienne Basset wrote:
> This patch creates auditing functions usable by LSM to audit security
> events. It provides standard dumping of FS, NET, task etc ... events
> (code borrowed from SELinux)
> and provides 2 callbacks to define LSM specific auditing, which should be
> flexible enough to convert SELinux too.
>
> Signed-off-by: Etienne Basset <etienne.basset(a)numericable.fr>
Acked-by: Eric Paris <eparis(a)redhat.com>
thanks!
Not worth doing another round, but if you do:
common_audit_data->function is (I think) SMACK specific, and probably
should live in the smack private union.
Yes, sure, but they also could use it. (i find it quite convenient)
thanks
Etienne