On Fri, 25 Aug 2017, Serge E. Hallyn wrote:
Part of the motivation here is that the things we are checking for
are some
rather baroque combinations of conditions, so having each piece of those be
as simple and clear as possible helps to better reason about what is going on
(which helped Richard to find the bug he is fixing).
These helpers are local (should all be static, as James pointed out). Making
helpers to simplify the final checks is the right way to clarify code. I'm
all for making sure they are as clear as possible, but I do think their existence
is justified.
Perhaps document them better and maybe prefix them with __ to emphasize
that they're internal only?
--
James Morris
<jmorris(a)namei.org>