Re: [PATCH 1/1] Added exe field to audit core dump signal log

On Wed, Nov 20, 2013 at 2:03 PM, William Roberts <bill.c.roberts(a)gmail.com&gt; wrote: > On Wed, Nov 20, 2013 at 1:47 PM, Richard Guy Briggs <rgb(a)redhat.com&gt; wrote: >> On Thu, Nov 14, 2013 at 08:56:57AM +0530, Paul Davies C wrote: >>> + if (mm) { >>> + down_read(&mm->mmap_sem); >>> + if (mm->exe_file) >>> + audit_log_d_path(ab, " exe=", &mm->exe_file->f_path); >>> + up_read(&mm->mmap_sem); >>> + } <snip> One other thing that I know Steve Grubb is picky on, is the field still needs to be there even if mm is null. We can't have disappearing fields. On error conditions, I've been doing <fieldname>=(null) on my patches.