Re: [PATCH] arm64: audit: Fix build for audit changes
On Fri, Jul 25, 2014 at 10:21:09AM +0100, Catalin Marinas wrote:
On Thu, Jul 24, 2014 at 08:12:37PM +0100, Mark Brown wrote:
> This is still broken -next.
It should now be temporarily fixed for the defconfig
(CONFIG_AUTIDSYSCALL disabled). I'm reluctant to merge the audit tree in
the arm64 tree as (a) I haven't seen a confirmation that this branch is
stable and will go upstream as is and (b) there are x86 changes without
Acks from the x86 maintainers (whether needed or not, I can't say).
I'd not expect it to be essential, it's just a function prototype
change.
So my temporary patch is some #ifndef's around the offending
code. It
will be reverted and your patch applied once the audit tree meets the
arm64 tree.
That's good thanks, though it's still going to mean we have massive
bisection breaks and anyone with an existing config will run into
trouble - I'm going to be adding all*config builds to my daily tests
soon too which will still trigger the issue).
I suspect the easiest thing would be to cherry pick the commit over (it
can always be reverted later on if there's an issue) if a shared branch
can't be arranged. It's a real shame Eric hasn't replied here...
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)