Re: [PATCH 03/15] tty: audit: Remove icanon mode from call chain

On 11/12/2015 09:15 PM, Richard Guy Briggs wrote: > On 15/11/12, Peter Hurley wrote: >> On 11/12/2015 02:10 PM, Richard Guy Briggs wrote: >>> On 15/11/10, Peter Hurley wrote: >>>> The tty termios bits cannot change while n_tty_read() is in the >>>> i/o loop; the termios_rwsem ensures mutual exclusion with termios >>>> changes in n_tty_set_termios(). Check L_ICANON() directly and >>>> eliminate icanon parameter. >>>> >>>> NB: tty_audit_add_data() => tty_audit_buf_get() => tty_audit_buf_alloc() >>>> is a single path; ie., tty_audit_buf_get() and tty_audit_buf_alloc() >>>> have no other callers. >>> >>> Which tree is this based on? I don't see where the first chunk applies. >> >> 4.3 >> >> but this series requires a -stable fix [1] posted earlier but not in any >> tree yet, which I noted in the cover-letter (was easy to overlook). > > Ok, found it. It appears to also depend on "n_tty: Uninline > tty_copy_to_user()" [2] which I didn't see mentioned and can't find > upstream. Sorry, my bad; I overlooked that dependency.

> Is that in an upstream tree? Not yet. That will end up in Greg's tty-next tree sometime shortly after the merge window closes. >> [1] https://lkml.org/lkml/2015/11/8/133 > > [2] https://lkml.org/lkml/2015/11/8/146