Re: [PATCH 1/3] kernel/audit: consolidate handling of mm->exe_file
On Sat, Feb 21, 2015 at 10:00 AM, Davidlohr Bueso <dave(a)stgolabs.net> wrote:
On Sat, 2015-02-21 at 08:45 -0500, Paul Moore wrote:
> On Fri, Feb 20, 2015 at 8:23 PM, Davidlohr Bueso <dave(a)stgolabs.net> wrote:
> > On Wed, 2015-02-18 at 22:23 -0500, Paul Moore wrote:
> >> I'd prefer if the audit_log_d_path_exe() helper wasn't a static
inline.
> >
> > What do you have in mind?
>
> Pretty much what I said before, audit_log_d_path_exe() as a
> traditional function and not an inline. Put the function in
> kernel/audit.c.
well yes I know that, which is why I showed you the code sizes. Now
again, do you have any reason? This function will only get less bulky in
the future.
The code size was pretty negligible from my point of view, not enough
to outweigh my preference for a non-inlined version of the function.
Also, I expect this function will be one of the things that gets
shuffled/reworked in the coming months as we make some architectural
changes to audit.
--
paul moore
www.paul-moore.com