Re: [PATCH v3 1/3] audit: replace magic audit syscall class numbers with macros

On 2021-05-10 21:23, Paul Moore wrote: > On Fri, Apr 30, 2021 at 4:36 PM Richard Guy Briggs <rgb(a)redhat.com&gt; wrote: > > > > Replace audit syscall class magic numbers with macros. > > > > This required putting the macros into new header file > > include/linux/auditscm.h since the syscall macros were included for both 64 > > bit and 32 bit in any compat code, causing redefinition warnings. > > The ifndef/define didn't protect against redeclaration? Huh. Maybe > I'm not thinking about this correctly, or the arch specific code is > doing something wonky ... > > Regardless, assuming that it is necessary, I would prefer if we called > it auditsc.h instead of auditscm.h; the latter makes me think of > sockets and not syscalls. The "m" was for "macros", since there are auditsc bits in audit.h as well, but I have no significant objection.