Re: [PATCH 3/3 RESEND] auditsc: Do not use RCU primitive to read from cred pointer

On Fri, Apr 3, 2020 at 5:22 PM Richard Guy Briggs <rgb(a)redhat.com&gt; wrote: > On 2020-04-03 13:26, Amol Grover wrote: > > On Thu, Apr 02, 2020 at 08:56:36AM -0400, Paul Moore wrote: > > > On Thu, Apr 2, 2020 at 1:57 AM Amol Grover <frextrite(a)gmail.com&gt; wrote: > > > > task_struct::cred is only used task-synchronously and does > > > > not require any RCU locks, hence, rcu_dereference_check is > > > > not required to read from it. > > > > > > > > Suggested-by: Jann Horn <jannh(a)google.com&gt; > > > > Co-developed-by: Joel Fernandes (Google) <joel(a)joelfernandes.org&gt; > > > > Signed-off-by: Joel Fernandes (Google) <joel(a)joelfernandes.org&gt; > > > > Signed-off-by: Amol Grover <frextrite(a)gmail.com&gt; > > > > --- > > > > kernel/auditsc.c | 15 +++++---------- > > > > 1 file changed, 5 insertions(+), 10 deletions(-) > > > > > > This is the exact same patch I ACK'd back in February, yes? > > > > > > https://lore.kernel.org/linux-audit/CAHC9VhQCbg1V290bYEZM+izDPRpr=XYXakoh... > > > > > > > Hi Paul, > > > > That's correct. I've resend the series out of the fear that the first 2 > > patches might've gotten lost as it's been almost a month since I last > > sent them. Could you please ack this again, and if you don't mind could > > you please go through the other 2 patches and ack them aswell? > > Via who's tree are you expecting this will make it upstream? When I asked a similar question back in February the response was basically not the audit tree.

paul moore