On Tue, Nov 28, 2006 at 07:27:02PM +0000, David Woodhouse wrote:
On Tue, 2006-11-28 at 11:18 -0800, Tony Jones wrote:
> I recall the opinion at the time was that it was considered useful to allow
> third party modules to generate audit messages. Has anything changed?
It should at least be EXPORT_SYMBOL_GPL, not EXPORT_SYMBOL.
So let's do at least the minimal patch noone disagrees with.
dwmw2
cu
Adrian
<-- snip -->
This patch changes some completely unused audit exports from
EXPORT_SYMBOL to EXPORT_SYMBOL_GPL.
They are still completely unused, but hopefully some of the theoretical
code that might use it will appear in the kernel in the near future...
Signed-off-by: Adrian Bunk <bunk(a)stusta.de>
--- linux-2.6.19-mm1/kernel/audit.c.old 2006-12-11 20:13:54.000000000 +0100
+++ linux-2.6.19-mm1/kernel/audit.c 2006-12-11 20:14:19.000000000 +0100
@@ -1209,7 +1209,7 @@
}
}
-EXPORT_SYMBOL(audit_log_start);
-EXPORT_SYMBOL(audit_log_end);
-EXPORT_SYMBOL(audit_log_format);
-EXPORT_SYMBOL(audit_log);
+EXPORT_SYMBOL_GPL(audit_log_start);
+EXPORT_SYMBOL_GPL(audit_log_end);
+EXPORT_SYMBOL_GPL(audit_log_format);
+EXPORT_SYMBOL_GPL(audit_log);