Re: [PATCH 0/11 v3] audit: Fix various races when tagging and untagging mounts
On 2018-09-04 18:06, Jan Kara wrote:
Hello,
Jan,
this is the third revision of the series that addresses problems I
have
identified when trying to understand how exactly is kernel/audit_tree.c using
generic fsnotify framework. I hope I have understood all the interactions right
but careful review is certainly welcome.
I've tried to review it as carefully as I am able. As best I understand
it, this all looks reasonable and an improvement over the previous
state. Thanks for the hard work.
FWIW,
Reviewed-by: Richard Guy Briggs <rgb(a)redhat.com>
The patches have been tested by a stress test I have written which
mounts &
unmounts filesystems in the directory tree while adding and removing audit
rules for this tree in parallel and accessing the tree to generate events.
Still some real-world testing would be welcome.
Changes since v2:
* Fixed up mark freeing to use proper pointer as pointed out by Amir
* Changed some naming based on Paul's review
Changes since v1:
* Split the last patch to ease review
* Rewrite test script so that it can be included in audit testsuite
* Some cleanups and improvements suggested by Amir
Honza
- RGB
--
Richard Guy Briggs <rgb(a)redhat.com>
Sr. S/W Engineer, Kernel Security, Base Operating Systems
Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635